unbridled-41 commented on PR #4255:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4255#issuecomment-5647667127
## Verification evidence
- **CI**: branch head `ea4ea0a16d5ec834ff5d657a3494f97e0135b4ce` (PR #4255)
has exactly one workflow run for this head: "CI" (pull_request event), run
34709685412, conclusion=startup_failure — the upstream workflow fails at
startup for every branch in this repository, producing no check-runs
(`check-runs total_count = 0`). Unrelated to this change; all local
verification below was run on this head.
- **Red light (unfixed code)**: with the regression test kept and the
baseline `GeneralSettingsTab.tsx` restored, `npx vitest run
src/pages/settings/__tests__/GeneralSettingsTab.test.tsx` → `Tests 1 failed |
6 passed (7)`, failing item `× saves llm fields from a fresh read instead of
the mount-time snapshot` with `AssertionError: expected "vi.fn()" to be called
with arguments: [ObjectContaining{…}]` (the payload carried the stale `openai`
values). A second guard was verified to have teeth separately: omitting the
post-save state sync makes the existing theme test fail with `Expected the
element to have class: ant-segmented-item-selected`.
- **Module tests (fixed)**: `npx vitest run
src/pages/settings/__tests__/GeneralSettingsTab.test.tsx` → `Tests 7 passed
(7)` (re-run after the final commit, post lint-staged formatting).
- **Full suite + baseline**: `npx vitest run` on this head → 120 files,
`Tests 2 failed | 980 passed (982)`; both failures are untouched files and
known load-fragile cases under the parallel suite — `ClusterPage.test.tsx` and
`ConsumerPage.test.tsx`; re-run in isolation → ClusterPage `Tests 25 passed
(25)`, ConsumerPage `Tests 31 passed (31)`. Zero failures in files touched by
this change.
- **Build**: `npx tsc -b` clean and `npm run build` (tsc -b + vite build)
succeeds on the final head. Note: an earlier state of this branch had a
`TS2322` in `loadFreshSettings` (returning the narrowed-`null` snapshot under a
`Promise<GeneralSettings>` contract); the final commit resolves it by passing
the current snapshot as the fallback parameter — `npx eslint .` → 0 errors, 10
warnings all in untouched files.
- **Diff self-check** (`git show --numstat`):
`web/src/pages/settings/GeneralSettingsTab.tsx +18/−3`,
`web/src/pages/settings/__tests__/GeneralSettingsTab.test.tsx +49/−0` — no
unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
