RockteMQ-AI commented on issue #11151: URL: https://github.com/apache/rocketmq/issues/11151#issuecomment-5655072475
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The issue is valid. `SubRemotingServer.shutdown()` bypasses the parent's graceful-shutdown configuration entirely: 1. **Missing grace period**: The sub-server sets its shutdown flag and immediately closes the listening channel, without waiting for the configured `shutdownWaitTimeMs`. 2. **No GO_AWAY response**: During the grace period, new connections should receive `GO_AWAY` responses for supported client versions, but the sub-server just drops them. 3. **Inconsistent behavior**: Clients connected to the sub-server port experience abrupt disconnection during rolling restarts, while clients on the main port get graceful handling. The proposed fix — propagating `gracefulShutdown` flag and `shutdownWaitTimeMs` to `SubRemotingServer` — is correct. Additional note: the `SubRemotingServer` should also register its `ChannelFuture` with the parent's shutdown hook to ensure ordered teardown. An automated fix proposal may be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
