RockteMQ-AI commented on issue #11153: URL: https://github.com/apache/rocketmq/issues/11153#issuecomment-5655077036
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** `remoting` module — `NettyRemotingClient`, housekeeping timer **Compatibility:** No breaking changes; internal refactoring only The analysis is sound. The dedicated `scanExecutor` for NameServer probes is redundant since Netty already handles asynchronous connection completion. Removing it simplifies the thread model and eliminates an unnecessary thread pool. Key considerations for the implementation: - The housekeeping timer callback must not block on connection futures — use the connection-completion callback to update the available NameServer list asynchronously. - Race conditions: if an address is removed and then a late callback fires, it must not restore the removed address. A generation counter or version check can handle this. - The `scanAvailableNameSrv` switch and probe interval should be preserved as-is. This is a clean improvement to the client's thread model. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
