lizhimins commented on PR #4142: URL: https://github.com/apache/rocketmq-dashboard/pull/4142#issuecomment-5679161795
Thanks for the contribution. We're closing this one on design grounds rather than implementation quality. Per the Studio instance model spec (`docs/studio-instance-model-spec.md`), topic and group names are **globally unique within a single Studio deployment** — the unique key is on `name`, not on `(cluster, instance, name)`. Scoping mock topic mutations by `instanceId` so that two instances can hold same-name topics encodes the opposite assumption into the mock layer, which then diverges from the real backend contract the mock is supposed to mirror. A mock that permits a state the server rejects will hide exactly the class of bug it should surface. If you're hitting cross-instance state bleed in mock mode, the right fix is to make the mock enforce the same global-uniqueness rule the server does (and reject the second create), not to partition it per instance. Happy to review a PR in that direction. Note also that separate Studio deployments are the supported answer for same-name resources across daily/staging/production. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
