lizhimins commented on PR #4179:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4179#issuecomment-5679165784
Thanks for the contribution. We have to close this one, starting with a
process issue: the title says "fix collections.emptylist() bug" but the diff
touches no Java at all — there is no occurrence of `Collections`, `emptyList`,
or any `.java` file — so the change can't be reviewed or released under that
description. On the substance, `key={selectedInstanceId}` forces a full remount
of a ~2000-line page, and because `useInstanceFilter` returns `undefined` until
the instance list resolves (and then may also `navigate(..., {replace:
true})`), the key changes on every initial load, so the page mounts and
remounts before the user does anything — re-running every effect and discarding
non-instance state such as search text, pagination and expanded rows. The page
already resets its instance-scoped state explicitly. Similarly, most of the
added DLQ/alerts resets are unreachable (those drawers and modals are masked,
so the instance or domain cannot change while they are open), and `s
etSearch('')` / `setPageSize(20)` discard user preferences rather than stale
scope. Please resubmit with an accurate title and, if the stale-state symptom
is reproducible, a failing test that shows it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
