lizhimins commented on PR #4158: URL: https://github.com/apache/rocketmq-dashboard/pull/4158#issuecomment-5679162952
Thanks for digging into the native aggregation window. We don't think a hard 400 is the right shape here: a window longer than the retained samples already degrades gracefully — `NativeAlertEvaluationService.aggregate` simply aggregates over whatever snapshots exist and falls back to the single sample when none do, and the design doc describes the window as bounded by the local snapshot store. `snapshotRetention` is a runtime-tunable property, so binding rule validation to it would reject previously valid stored rules on unrelated edits (renaming a rule would 400 after an operator shortens retention) and would break cross-environment import, which runs through `createRule` inside one transaction. It also puts `Duration.parse` of operator-supplied config on the request path, turning a config typo into a 500. If you'd like to pursue this, a better direction is documenting the effective window or warning in the UI rather than rejecting the write. Happy to review a revised approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
