Aias00 opened a new pull request, #4334:
URL: https://github.com/apache/rocketmq-dashboard/pull/4334

   ## Summary
   
   - keep the existing atomic alert-rule import endpoint and behavior
   - include the existing rule name in semantic-duplicate 409 errors
   - show backend import error details instead of replacing them with the 
generic file error
   - remove the previous preview/apply workflow, conflict strategies, 
replacement behavior, and mock rule-ID change
   
   This rework follows the maintainer feedback on #4180 and deliberately limits 
the change to actionable import errors.
   
   ## Verification
   
   - `mvn -B -ntp -q -Dspring.profiles.active=dev 
-Dtest=AlertServiceTest,AlertRuleTransferServiceTest,AlertRuleControllerTest,ClusterAlertRuleControllerTest
 test` (108 passed)
   - `mvn -B -ntp -q -DskipTests package`
   - `npm test -- --run src/api/ops.test.ts src/services/opsService.test.ts 
src/pages/ops/__tests__/AlertsPage.test.tsx` (63 passed)
   - `npm run build`
   - changed-file ESLint (0 errors; 5 pre-existing warnings)
   - changed-file Prettier check
   - `git diff --check`
   
   Fixes #4178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to