yyqdbngt commented on PR #3925: URL: https://github.com/apache/rocketmq-dashboard/pull/3925#issuecomment-5691163060
Superseded by `#4123` (`fix(group): allow zero retry settings on update`, commit `c7193109`), so I am closing this. The base branch already carries the substance of this PR — `UpdateConsumerGroupSettingsDTO` now uses `@PositiveOrZero(message = "retryQueueNums must be zero or positive")`, and `UpdateConsumerGroupSettingsDTOTest` on `rocketmq-studio` already contains `shouldAcceptZeroRetrySettingsTest` and `shouldRejectNegativeRetrySettingsTest` with the same rationale. One assertion here is actively wrong against the merged behaviour: `retrySettingsShouldBeRequiredAndPositive` expects `retryQueueNums = 0` to produce `"retryQueueNums must be positive"`, but the base now accepts `0`. Rebased locally, that test fails (`Expecting actual: [] to contain exactly in any order: ["retryQueueNums must be positive"]`) while the rest of the file passes, i.e. this PR would have to drop the assertion it was arguing for. Nothing to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
