lizhimins commented on PR #4236: URL: https://github.com/apache/rocketmq-dashboard/pull/4236#issuecomment-5694505753
Closing, but please read this one as a request to resubmit rather than a rejection of the approach. Putting the helper in `common/util/SqlLikeUtils` is exactly the shape we want, and this is the only patch in the LIKE-escape set that covers all four call sites in `RocketMQMetadataProvider` plus `MybatisPlusSettingsRepository` without touching the hard-coded `notLikeRight`. The blocking problem is dialect dependence: the escaping relies on MySQL's implicit backslash escape character, and without an explicit `ESCAPE` clause the same helper is wrong elsewhere — five tests in this suite run against H2, which has no default LIKE escape character, so the escaped pattern silently means something different there. Add the explicit `ESCAPE` clause (and keep the tests asserting the bound parameter) and we will take it as the anchor for the whole cluster: #4192 #4193 #4194 #4224 #4230 #4233 #4290 are all closed or returned, so this is the one that should land. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
