lizhimins commented on PR #4288: URL: https://github.com/apache/rocketmq-dashboard/pull/4288#issuecomment-5694508995
Backing off the cut when it lands between a high and a low surrogate does prevent a lone surrogate from reaching the JSON encoder. The fix itself is sound and comes with a test, so this is not a quality call. We have stopped merging one-defect-per-PR patches out of this queue: the review and merge overhead per change is high, and several of them touch files that other open PRs also touch. Please regroup your open Studio fixes into one PR per functional domain (for example instance/cluster persistence, alert rendering, AI tool input validation) and resubmit against the current `rocketmq-studio` baseline — we will review the consolidated PRs. When you regroup, note that other authors' patches on the same files are also being closed, so please pick one approach per file rather than resubmitting the overlap. One note for the regroup: `MessagePropertyDisplay.abbreviate` is also touched by #4226, which we are closing too, and by #4170, whose author closed it as a duplicate of #4226. Whichever variant you resubmit, please cover `hasOversizedProperty` and the javadoc in the same change — a fix that only pins `abbreviate` still lets an oversized value fall back to `value.length()` and split a surrogate pair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
