lizhimins commented on PR #4290: URL: https://github.com/apache/rocketmq-dashboard/pull/4290#issuecomment-5694510141
Escaping the audit search term so `%` and `_` match literally is the right behaviour. The fix itself is sound and comes with a test, so this is not a quality call. We have stopped merging one-defect-per-PR patches out of this queue: the review and merge overhead per change is high, and several of them touch files that other open PRs also touch. Please regroup your open Studio fixes into one PR per functional domain (for example instance/cluster persistence, alert rendering, AI tool input validation) and resubmit against the current `rocketmq-studio` baseline — we will review the consolidated PRs. When you regroup, note that other authors' patches on the same files are also being closed, so please pick one approach per file rather than resubmitting the overlap. For the regroup: this is the same repository method that #4192 patches, and it adds another private `escapeLike` copy. We are consolidating LIKE escaping into one shared utility, and the escape also needs an explicit `ESCAPE` clause — the helper currently relies on MySQL's implicit backslash, which H2 (used by five tests in this suite) does not provide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
