89799969 opened a new pull request, #4372:
URL: https://github.com/apache/rocketmq-dashboard/pull/4372

   ## Summary
   
   Fixes #4297
   
   A rule whose stored `instanceId` has surrounding whitespace fires via 
`NativeAlertRuleScopeMatcher` (trims) but was dropped from 
`MybatisPlusAlertStateRepository.findActive` and 
`NativeAlertProcessor.reconcileMissingActiveStates`. Operators saw "no active 
alert" while FIRING rows kept being written.
   
   Trim the stored instance id in both filters, matching the metric filter on 
the previous line.
   
   ## Testing
   
   - 
`MybatisPlusAlertStateRepositoryTest#findsActiveStatesForRulesWithPaddedStoredInstanceIdTest`
 (new)
   - `MybatisPlusAlertStateRepositoryTest`: 6 passed locally
   
   ## AI disclosure
   
   Implemented with the assistance of an AI coding agent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to