Aias00 opened a new pull request, #4389: URL: https://github.com/apache/rocketmq-dashboard/pull/4389
## Summary - explain that Studio connects directly to the configured NameServer address; - document SLB/VIP addresses, headless Service DNS names, and comma-separated address lists; - clarify that the address must be reachable from the Studio server; - show the guidance only on the NameServer management tab and reuse the existing localized `InfoBanner`; - keep the form placeholder and extra text aligned with the same contract. ## Scope - no Kubernetes client or Kubernetes API integration; - no automatic discovery, RBAC, background synchronization, or backend behavior; - implements the scoped UX direction requested by the maintainer on #3133; - rebuilt as one signed-off commit from current `rocketmq-studio` (`e5ac52440`). ## Review follow-up The banner was moved from `renderBrokerTab()` to `renderNameServerTab()`. The regression now asserts it is absent on the default Broker tab before switching to NameServer, so the original placement bug cannot pass unnoticed. ## Verification - focused tests: 3 files, 36 tests passed; - `ClusterPage.test.tsx`: 27 tests passed; - production build passed (8,046 modules transformed); - ESLint: 0 errors, 10 existing warnings in unrelated files; - changed-file Prettier check passed; - `git diff --check` passed; - independent review found no remaining issues. The current repository-wide frontend suite has an unrelated timing failure in `UserManagement.test.tsx` when run as part of the full set (1034/1035 passed); that exact failing test passes in isolation. No changed-scope test is failing. Fixes #4346 Follow-up to the Kubernetes discovery direction closed as not planned in #3132. Supersedes #3133 based on maintainer feedback. --- Replaces #4128 because its base branch (`rocketmq-studio`) was deleted. This PR uses the same head commit and targets `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
