Aias00 opened a new pull request, #4468:
URL: https://github.com/apache/rocketmq-dashboard/pull/4468
### Which Issue(s) This PR Fixes
- Fixes #4463
### Brief Description
Prevent topic-wide producer connection queries from returning an apparently
complete inventory after
part of the scan fails:
- require every Broker producer table to be readable when discovering active
groups for the
aggregate connection query;
- fail with HTTP 502 when any discovered group's real connection RPC fails;
- continue treating an offline producer group as a valid empty result;
- preserve best-effort producer-group suggestions, explicit-group queries,
and the general Clients
page scan.
The response schema and frontend behavior are unchanged; the existing error
path now surfaces an
unavailable aggregate instead of misleading partial data.
### How Did You Test This Change?
- `cd server && SPRING_PROFILES_ACTIVE=dev JAVA_HOME=<jdk21> mvn -B -ntp
test`
- 2417 tests passed, including ArchUnit and H2/MySQL-compatible
integration tests.
- Focused provider/service/controller suite: 43 tests passed.
- `cd server && JAVA_HOME=<jdk21> mvn -B -ntp -DskipTests package`
- Checkstyle, compilation, JAR packaging, and Spring Boot repackaging
passed.
- `cd web && npm test`
- 122 test files and 1034 tests passed.
- `cd web && npm run lint`
- 0 errors; 10 pre-existing warnings outside the changed code.
- `cd web && npm run build`
- TypeScript and Vite production build passed.
- Independent code review reported no findings; `git diff --check` passed.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (`feat:` / `fix:` /
`refactor:` / `chore:` / `docs:` / `perf:`)
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
(no UI changes)
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks)
- [x] New source files carry the ASF license header (no new source files)
- [x] Documentation impact is captured in #4463; no public API schema changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
