lizhimins commented on PR #4192: URL: https://github.com/apache/rocketmq-dashboard/pull/4192#issuecomment-5694493936
Closing as part of consolidating the LIKE-escape work. The escaping is needed, but this patch adds a private `escapeLike` copy in the audit repository (the third one across #4192 #4193 #4194), and the whole set relies on MySQL's implicit backslash escape character with no explicit `ESCAPE` clause — which is wrong on H2, where five tests in this suite run. See #4236: we asked for the shared `SqlLikeUtils` version with an explicit `ESCAPE` clause, and that one should land first. Note also that #4191 moved `findPage` onto `applyFilters`, so the patch needs rebasing regardless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
