RockteMQ-AI commented on PR #1356: URL: https://github.com/apache/rocketmq-clients/pull/1356#issuecomment-5703443870
⚠️ **Scope expansion detected** This PR was originally titled **[ISSUE #1306] [Go] Support custom logger injection** and was previously approved for that scope. Since the last review, **9 new commits** have been added that expand the PR to include: - **C#**: LiteSimpleConsumer implementation (~2,500+ lines), ClientManager refactoring, Session changes - **Python**: LiteSimpleConsumer, route manager refactoring, client manager changes - **Node.js**: Multiple client changes - **Go**: Client manager refactoring beyond the original logger injection The PR title and description no longer match the actual changes. This makes it difficult for reviewers to understand the full scope and for maintainers to evaluate the change holistically. **Recommendation:** Please consider splitting this into separate, focused PRs: 1. One PR for the Go custom logger injection (original scope — already approved) 2. Separate PRs for each language's LiteSimpleConsumer / other changes This helps reviewers focus on one concern at a time and makes the git history clearer. --- *Automated review by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
