RockteMQ-AI commented on PR #1346: URL: https://github.com/apache/rocketmq-clients/pull/1346#issuecomment-5703447155
⚠️ **Scope expansion detected** This PR was originally titled **[ISSUE #1345] [Go] Filter non-writable broker queues for producer** and was previously approved for that scope. Since the last review, **new commits** have been added that expand the PR to include: - **C#**: LiteSimpleConsumer implementation (~2,500+ lines), ClientManager refactoring, Session changes - **Python**: LiteSimpleConsumer, route manager refactoring, client manager changes - **Node.js**: Multiple client changes - **Go**: Client manager refactoring beyond the original queue filtering fix The PR title and description no longer match the actual changes. The original fix (filtering non-writable master queues in `PublishingLoadBalancer`) was clean and well-tested — it should be easy to split out. **Recommendation:** Please consider splitting this into separate, focused PRs: 1. One PR for the Go producer queue filtering fix (original scope — already approved) 2. Separate PRs for each language's LiteSimpleConsumer / other changes --- *Automated review by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
