RockteMQ-AI commented on code in PR #1379:
URL: https://github.com/apache/rocketmq-clients/pull/1379#discussion_r4033959336
##########
nodejs/src/consumer/index.ts:
##########
@@ -34,6 +34,7 @@ export * from './LiteStandardConsumeService';
export * from './ProcessQueue';
export * from './PushConsumer';
export * from './LitePushConsumer';
+export * from './LiteSimpleConsumer';
Review Comment:
f1amingo's earlier comment is still unaddressed: `export * from
'./LiteSimpleConsumer'` re-exports `LiteSimpleConsumerImpl` (which is declared
in that file), leaking host-only methods (`getRpcClientManager`, `getLogger`,
etc.) into the published `.d.ts`. Once the npm package ships, this becomes a
breaking change to fix.
Suggested fix — replace the barrel export with selective exports:
```ts
export { LiteSimpleConsumer, LiteSimpleConsumerBuilder, OffsetOption } from
'./LiteSimpleConsumer';
// or split: keep the interface+builder in LiteSimpleConsumer.ts and move
Impl to a separate file
```
This matches how `SimpleConsumerImpl` is kept unexported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
