RockteMQ-AI commented on issue #11172: URL: https://github.com/apache/rocketmq/issues/11172#issuecomment-5711058183
**Issue Evaluation** Category: `bug` | Status: **Confirmed** This is a well-analyzed control-flow defect in `DefaultMessageStore.asyncPutMessage`. The issue correctly identifies that when `asyncPutMessageFuture` is already completed exceptionally at entry, the method returns without invoking the `handleDiskFlush` callback, leaving the caller (e.g. `AsyncSenderProcessor`) waiting until timeout. **Root Cause:** The `asyncPutMessageFuture.isDone()` short-circuit bypasses the `handleDiskFlush.accept(...)` callback that normally resolves the put-result future. **Impact:** Async send callers hang until timeout when the store future fails synchronously. This is a correctness issue affecting send reliability. **Severity:** High - affects async message send reliability, can cause cascading timeouts. **Assessment:** The proposed fix is correct: invoke `handleDiskFlush` with the exceptional result before the early return. The fix is minimal and preserves existing behavior for the normal path. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
