RockteMQ-AI commented on issue #11168: URL: https://github.com/apache/rocketmq/issues/11168#issuecomment-5711066038
**Issue Evaluation** Category: `bug` | Status: **Confirmed** This is a comprehensive and well-documented analysis of six distinct defects in the tiered storage error-reporting path. The issue correctly identifies that transient upload failures (`IOException`, `TimeoutException`, `ClosedChannelException`) are misreported as file-size lookup errors due to the unconditional `getFileLengthAsync` fallback in `TieredCommitCallbackImpl`. **Root Cause:** The `onException` handler unconditionally attempts `getFileLengthAsync` regardless of the actual failure type, and when that also fails, the original exception is lost and replaced with a misleading "failed to get file size" error. **Impact:** - Monitoring/alerting systems receive incorrect error classifications - Operations teams cannot distinguish transient upload failures from actual file-size lookup problems - Error metrics are inaccurate, affecting capacity planning and incident response **Severity:** Medium - affects observability and operational response, not data correctness. **Assessment:** The proposed fix scope is appropriate: 1. Preserve the original exception type and message 2. Only attempt file-size lookup when it is meaningful 3. Add proper error classification for different failure modes The fact that the author has a tested patch ready is excellent. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
