jokerzsd opened a new pull request, #4522:
URL: https://github.com/apache/rocketmq-dashboard/pull/4522

   ### Which Issue(s) This PR Fixes
   
   Fixes #4520.
   
   ### Brief Description
   
   NameServer registration lowercases an entire IPv6 literal, so 
`[FE80::ABCD%ProdNIC]:9876` is saved as `[fe80::abcd%prodnic]:9876`. A named 
zone must match the interface name exactly ([JDK 
documentation](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/net/Inet6Address.html)).
 Changing its case can make the endpoint refer to a nonexistent interface.
   
   Lowercase only the address portion and retain the zone suffix unchanged. Add 
coverage for named and numeric zones, including the create/update values passed 
to the registry mapper. DNS normalization and existing address validation 
remain unchanged.
   
   ### How Did You Test This Change?
   
   - Before the fix: 40 parser/registry tests ran, with exactly 3 failures for 
named-zone preservation (parser, create, update).
   - After the fix: full `mvn` server build is green — `NamesrvAddrParserTest` 
(18 tests) and `NameserverRegistryServiceTest` (22 tests) pass, 73 tests total 
with 0 failures/errors.
   - `git diff --check` passed.
   
   Verification used Temurin JDK 21 and Maven 3.9.16 on Windows. Tests do not 
require a locally configured interface; registry persistence is checked with 
the existing mocked mapper. No live IPv6 NameServer or database integration 
test is claimed.
   
   ### Checklist
   
   - [x] One focused fix with regression tests and DCO signoff
   - [x] Checked open/closed/merged PRs, including #2745, #2869, #2469 and 
#4154; those do not preserve named scope casing
   - [x] Existing ASF headers retained; no new UI strings, API changes or 
dependencies
   - [x] AI assistance disclosed: source analysis, implementation and test 
authoring
   - [ ] Full backend integration suite (not run; validation scope is stated 
above)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to