zmuxuny commented on PR #4512: URL: https://github.com/apache/rocketmq-dashboard/pull/4512#issuecomment-5718801120
Audit follow-up: I found one scope-preservation edge while re-reviewing the open PR set. Per-group UNAVAILABLE cloud lag samples were dropping the group's `clusterId`, so a native alert rule with `clusterName` could fail to match the unavailable sample during reconciliation. The branch now preserves `group.clusterId` on per-group/group-topic UNAVAILABLE samples while keeping whole-instance failure markers unscoped. The existing unknown-lag test now asserts the cluster id as part of the availability contract. Re-verified on Java 21: `TencentInstanceProviderTest,CloudRocketMqBusinessMetricsCollectorTest,NativeAlertProcessorTest` **70/70 passed**, Checkstyle 0; `mvn -B -ntp -DskipTests package` BUILD SUCCESS; `git diff --check` clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
