X-LightYear opened a new pull request, #4553: URL: https://github.com/apache/rocketmq-dashboard/pull/4553
## Summary - keep completed MCP tool results independent from audit persistence failures - preserve the original tool error when failed-execution auditing also fails - add regression coverage for both audit-failure paths ## Root cause `ToolAuditFilter` recorded audit entries synchronously after the tool outcome was already known. An audit persistence exception could therefore escape the filter and replace the actual tool result, causing a completed operation to be reported as an execution failure. ## Fix Treat audit persistence as observational at the tool execution boundary. - successful tool output is preserved when SUCCESS audit recording fails - original tool failures are preserved when FAILED audit recording also fails - audit persistence failures are logged for diagnosis ## Testing - `McpToolRegistrarTest`: 3 passed - `ToolMutationFilterTest`: 5 passed - `ToolExecutorInvocationTest`: 8 passed - `ToolInstanceRoutingTest`: 4 passed - focused tool suite: 20 passed - Checkstyle: 0 violations - `mvn -DskipTests package`: passed Fixes #4552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
