f1amingo commented on PR #1373: URL: https://github.com/apache/rocketmq-clients/pull/1373#issuecomment-5747969813
**Nice cleanup on the reconnect timer leak.** One blocking issue before merge: ### `refresh()` permanently disables auto-reconnect `release()` now permanently sets `#released = true`, and `#scheduleRenewStream()` early-returns when released. But `refresh()` (triggered by the server's `ReconnectEndpointsCommand`) still calls `release()` — so after any refresh, the session can never auto-reconnect on a later `error`/`end`, silently. **Fix:** in `refresh()`, tear down the old stream via `#closeStream()` instead of `release()`. Keep `release()` only for real shutdown (`#releaseTelemetrySessions()`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
