unbridled-41 commented on PR #4604:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4604#issuecomment-5749610261
## Verification evidence
**CI (this head SHA)** — `511cdf07c3b1e5c939597ecf46f68fc098913424`: exactly
one `CI` (`pull_request`) run, id `35507315861`, `status=completed`,
`conclusion=startup_failure`; `check-runs=0`; combined status `state=pending,
count=0`. Repo-wide condition (all recent `pull_request` runs are
`startup_failure`, other contributors' PRs included).
**Red before the fix** — `web/src/pages/instance/consumer.tsx` restored from
`origin/master` with the new test kept:
```
× does not report a failed progress load as an offline consumer group 7772ms
Tests 1 failed | 32 skipped (33)
```
The assertion that first fails is the empty-state claim `消费组不在线，暂无队列进度数据`
found in the progress panel.
**Module tests (green)**
```
npx vitest run --maxWorkers=2
src/pages/instance/__tests__/ConsumerPage.test.tsx -t "failed progress load"
Tests 1 passed | 32 skipped (33)
npx vitest run --maxWorkers=2
src/pages/instance/__tests__/ConsumerPage.test.tsx -t "keeps the latest client
stack when an older request resolves last"
Tests 1 passed | 32 skipped (33)
npx vitest run --maxWorkers=2
src/pages/instance/__tests__/ConsumerPage.test.tsx -t "loads a consumer client
stack trace from the selected instance"
Tests 1 passed | 32 skipped (33)
```
The whole file run in one process is load-sensitive in this sandbox (both
here and on the other branches of this batch), which is why the three affected
cases are reported individually as well.
**Full web suite** — `cd web && npx vitest run --maxWorkers=4`:
```
Test Files 2 failed | 120 passed (122)
Tests 2 failed | 1033 passed (1035)
```
Failures: `ConsumerPage > keeps the latest client stack when an older
request resolves last` and `NotificationDeliveriesPage > refreshes a completed
retry with the latest filters`. Both are in files this PR does not change. The
`ConsumerPage` file restored from `origin/master` fails the same assertion
under the same load (`Tests 1 failed | 31 skipped`), and
`NotificationDeliveriesPage` is the load-flaky file that also failed in earlier
full runs of this sandbox; this PR's new test passes in the module run above.
**Build** — `npx tsc -b`: clean. `npx eslint src/pages/instance/consumer.tsx
src/pages/instance/__tests__/ConsumerPage.test.tsx`: 0 errors, 0 warnings.
**Diff self-check** — `git diff --numstat origin/master` → `32/1
web/src/pages/instance/consumer.tsx`, `39/0
web/src/pages/instance/__tests__/ConsumerPage.test.tsx` (2 files, net +71/−1).
The `−1` in the page component is the replaced `if (!silent)
message.error(...)` line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
