unbridled-41 commented on PR #4602:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4602#issuecomment-5749609894
## Verification evidence
**CI (this head SHA)** — `a9859a8abb70072632a0a81fbd54cf2e79eb1f93`: exactly
one `CI` (`pull_request`) run, id `35507300944`, `status=completed`,
`conclusion=startup_failure`; `check-runs=0`; combined status `state=pending,
count=0`. The same failure applies to every recent run in this repository (all
`pull_request` runs on the front page are `startup_failure`), i.e. the workflow
never starts for anyone, including PRs from other contributors.
**Red before the fix** — baseline `origin/master` source restored (`git
checkout origin/master -- web/src/pages/instance/topic.tsx`) with the new test
kept:
```
× reloads the paginated inventory after importing topics 7830ms
TestingLibraryElementError: Unable to find an element with the text: /共 1 个
Topic/.
Tests 1 failed | 26 skipped (27)
```
**Module tests (green)** — `cd web && npx vitest run --maxWorkers=2
src/pages/instance/__tests__/TopicPage.test.tsx`:
```
Test Files 1 passed (1)
Tests 27 passed (27)
```
(26 pre-existing + 1 new.)
**Full web suite** — `cd web && npx vitest run --maxWorkers=4`:
```
Test Files 2 failed | 120 passed (122)
Tests 3 failed | 1032 passed (1035)
```
The three failures are `ConsumerPage > keeps the latest client stack when an
older request resolves last`, `ConsumerPage > loads a consumer client stack
trace from the selected instance` and `TopicPage > keeps failed topics selected
after a partially successful batch deletion` — all in code this PR does not
touch. This sandbox is load-sensitive for these files: the same full run
repeated on the sibling branches of this batch produced a different (smaller)
failure set, and the added `TopicPage` test passes in the module run above. A
baseline comparison for the recurring `ConsumerPage` case is included in the
other PRs of this batch: the file restored from `origin/master` fails the same
assertion under the same load (`Tests 1 failed | 31 skipped`).
**Build** — `npx tsc -b`: clean (no output). `npx eslint
src/pages/instance/topic.tsx src/pages/instance/__tests__/TopicPage.test.tsx`:
0 errors, 0 warnings. `npm run build`: not re-run for this branch; the change
is two lines in an existing handler and `tsc -b` covers the type surface.
**Diff self-check** — `git diff --numstat origin/master` → `29/0
web/src/pages/instance/__tests__/TopicPage.test.tsx`, `3/4
web/src/pages/instance/topic.tsx` (net +32/−4, 2 files). No unrelated change;
the commit does not touch the import dialog's row-status handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
