unbridled-41 commented on PR #4586:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4586#issuecomment-5748297117
### Verification evidence
**CI** — this PR's head is `391b2283a3f02ce7b771746d843190b1dad99fdb`.
GitHub reports exactly one workflow run for it: `35495931781` `CI`
(`pull_request`) → `startup_failure` (2026-09-20T07:05:20Z); `check-runs` = 0
and the combined status is `pending` with 0 statuses. This is the
repository-level failure that affects every branch, including `master`'s own
recent runs (the same result was observed for this repository's other PRs
today), so nothing ran and the checks below were executed locally.
```
$ gh api "repos/apache/rocketmq-dashboard/actions/runs?head_sha=391b2283..."
--jq '.workflow_runs[] | "\(.id) \(.name) \(.event) \(.conclusion)"'
35495931781 CI pull_request startup_failure
$ gh api "repos/apache/rocketmq-dashboard/commits/391b2283.../check-runs"
--jq .total_count
0
```
**Red-light (base source + new test)**
```
$ git checkout origin/master --
web/src/components/TopicConfigComparisonDrawer.tsx # d50ffecc
$ npx vitest run
src/components/__tests__/TopicConfigComparisonDrawer.test.tsx
FAIL src/components/__tests__/TopicConfigComparisonDrawer.test.tsx >
TopicConfigComparisonDrawer > discards a comparison that resolves after the
instance pair changed
Error: expect(element).not.toBeInTheDocument()
expected document not to contain element, found <div
class="ant-statistic-title">配置一致</div> instead
❯ src/components/__tests__/TopicConfigComparisonDrawer.test.tsx:243:44
Test Files 1 failed (1)
Tests 1 failed | 7 passed (8)
```
**Module tests (with the fix)**
```
$ npx vitest run
src/components/__tests__/TopicConfigComparisonDrawer.test.tsx
Test Files 1 passed (1)
Tests 8 passed (8)
$ npx vitest run src/pages/instance/__tests__/TopicPage.test.tsx # page
that mounts the drawer
Test Files 1 passed (1)
Tests 26 passed (26)
```
**Full suite + baseline**
```
$ npx vitest run --maxWorkers=4 # branch head
Test Files 122 passed (122)
Tests 1035 passed (1035)
```
`1035 = 1034 (pristine origin/master) + 1 new test`; the same suite reported
`1038` earlier in this session while three other in-progress regression files
were still in my local tree, which cross-checks the 1034 baseline.
The default-parallel `npx vitest run` on this same head reported `23 failed
| 1012 passed (1035)` across 10 files — all of them files this PR does not
touch (MetricsExplorer 1, ClientsPage 1, ClusterPage 3, ConsumerPage 6,
InstancePage 2, MessagePage 1, MessagePageAsyncState 1, TopicPage 3, AlertsPage
3, AuditPage 1). These are the load-fragile files that also fail intermittently
on pristine `master` when the whole suite runs in parallel (two pristine runs
recorded earlier in this session produced 14 and 22 such failures). Isolating
exactly those 10 files:
```
$ npx vitest run <those 10 files>
Test Files 10 passed (10)
Tests 226 passed (226)
```
**Build**
```
$ npx tsc -b # clean (exit 0)
$ npx eslint src/components/TopicConfigComparisonDrawer.tsx
src/components/__tests__/TopicConfigComparisonDrawer.test.tsx
# no output: 0 errors, 0 warnings
$ npm run build # ✓ built in 14.80s
```
**Diff self-check**
```
$ git show --numstat --format="" HEAD
11 3 web/src/components/TopicConfigComparisonDrawer.tsx
29 1
web/src/components/__tests__/TopicConfigComparisonDrawer.test.tsx
```
One commit, two files, no unrelated changes: the source diff adds the
`invalidateComparison` helper (with the comment explaining why `loading` is
cleared) and replaces the three `setResult(null)` calls that belong to pair
changes; the test diff adds the held-open-request regression case plus the
`act` import it needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
