unbridled-41 commented on PR #4658:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4658#issuecomment-5754343849
## Verification evidence
- **CI**: run `35551762247` ("CI", event `pull_request`) at head `980eb5dc`
— conclusion `startup_failure` (the workflow never starts; repository-level
issue, other open PRs from the same window show the same). `check-runs`: 0. All
results below are from local runs of the exact head commit.
- **Red** (new regression on master source):
`expect(listAlertRulesPage).toHaveBeenLastCalledWith('CLUSTER',
expect.objectContaining({ page: 2 }))` failed — the post-delete refresh was
issued with `page: 1` (the removed branch decremented the page after the
full-page delete).
- **Module**: `npx vitest run src/pages/ops/__tests__/AlertsPage.test.tsx` →
`Tests 27 passed (27)` (26 pre-existing + 1 new).
- **Full web suite** (this branch, head `980eb5dc`): `npx vitest run
--maxWorkers=4` → `Test Files 122 passed (122)`, `Tests 1035 passed (1035)`,
zero failures. Pristine master baseline on this machine: 1034 passing; 1035 =
baseline + 1 new test.
- **Build**: `npm run build` → `✓ built in 9.89s` (exit 0). Type check `npx
tsc --noEmit` → clean. `npx eslint` on the two changed files → 0 errors, 5
warnings, all verified as pre-existing by stashing the changes and re-running
eslint on the master versions (same 5 warnings).
- **Diff self-check** (`git diff --numstat
origin/master..fix/alerts-bulk-delete-page`): `4/2
web/src/pages/ops/alerts.tsx`, `40/0
web/src/pages/ops/__tests__/AlertsPage.test.tsx` — 2 files, no unrelated
changes. Single commit `980eb5dc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
