lizhimins commented on PR #4594: URL: https://github.com/apache/rocketmq-dashboard/pull/4594#issuecomment-5755991562
Closing as a duplicate of #4490, which has been merged into `rocketmq-studio` as 2945fba. Both PRs make the same change: split `TopicPage` into a thin shell plus `TopicPageContent` keyed by the selected instance id, so the search text, filters, pagination, row selection and open dialogs reset when the operator switches instance. The resulting `web/src/pages/instance/topic.tsx` blob is byte-identical between the two branches (`439d0b530`), and #4490 was opened three days earlier, so that is the one that landed. Nothing wrong with the change itself — the test you added is mutation-sensitive in exactly the way we want, since dropping the `key` turns it red. #4597 describes the same defect as #4489 and is fixed by the same commit, so it has been closed as completed too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
