btlqql commented on PR #4695: URL: https://github.com/apache/rocketmq-dashboard/pull/4695#issuecomment-5757218634
Closing this as superseded by #4717, which now covers the same defect for both lookups in one place: - the key branch of `MessageService.queryMessages` (the `validateTopicQueryWindow` early bail-out), and - `MessageService.queryMessageByUniqueKey` (which does not call `validateTopicQueryWindow` at all - the reason this PR existed). Both callers now share a single private helper, `MessageService.validateProvidedTimeWindow`, so there is one implementation of the rule and one place to change it. This PR's tests were carried over to #4717 unchanged (`uniqueKeyQueryRejectsInvertedTimeWindowBeforeCallingProviderTest`, `uniqueKeyQueryRejectsNegativeTimeWindowBeforeCallingProviderTest`, plus `uniqueKeyQueryKeepsTheTimeWindowOptionalTest` / `uniqueKeyQueryAcceptsASingleSidedTimeWindowTest`), and the unique-key half was re-verified red on that branch with only that guard removed. The two PRs also could not both merge: each added its helper at `MessageService.java` line ~204 and inserted its test at the same `MessageServiceTest.java` anchor, so whichever landed second would have conflicted textually. Keeping one PR is the honest resolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
