RockteMQ-AI commented on issue #4753: URL: https://github.com/apache/rocketmq-dashboard/issues/4753#issuecomment-5760182289
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue is valid. The analysis is thorough and the root cause is clear. **Root Cause:** `internal/studio/agent.go` `Retention()` calls `conversationStore.Delete(id)` which removes the conversation record but does not clean up the agent workspace directory under `AgentWorkspaceDir`. The workspace cleanup only happens in `deleteConversation()` (the explicit delete path), not in the retention sweep. **Impact:** Over time, orphaned agent workspace directories accumulate on disk, consuming storage. The workspaces contain agent scratch files, tool outputs, and potentially sensitive data that should be purged with the conversation. **Severity:** Medium — storage leak that grows with retention cycles. No data corruption, but violates the expected cleanup contract. **Fix:** PR #4754 is referenced by the author. The fix should extend `Retention()` to also remove the agent workspace directory when deleting expired conversations, mirroring the cleanup in `deleteConversation()`. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
