Aias00 commented on PR #4387: URL: https://github.com/apache/rocketmq-dashboard/pull/4387#issuecomment-5760226437
Withdrawing this PR after evaluating the requested direction call. The default RocketMQ connection should remain fail-closed and non-editable at runtime under the current instance model. The model requires explicit `instanceId` routing with no default-injection design, so continuing to persist and apply a mutable no-instance connection would deepen a path the project is moving away from. The Ops persistence and deploy/configuration portions will not be split into follow-up PRs. The concurrency-safe part remains independently useful when `InstanceService` releases clients after an endpoint or credential update. I extracted that into design issue #4755 and focused PR #4761: - 5 files only: `ClientLease`, `MqAdminExtFactory`, `MqClientPool`, and focused tests - no Ops persistence, default routing, provider constructor changes, application configuration, or deploy files - full backend verification: 3079 passed, 3 skipped; independent concurrency re-review approved Issue #4348 is being closed as not planned for the same instance-model reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
