RockteMQ-AI commented on issue #4763:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/4763#issuecomment-5760911985

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase.
   
   **Root Cause:** Test fixtures and mock datasets in `api/*.test.ts` and 
`mock/*.ts` use hardcoded values (e.g. `status: 'active'`, `language: 'JAVA'`, 
`deliveryStatus: 'SUCCESS'`, `level: 'critical'`) that do not match the actual 
enum/provider values returned by the backend (`ACTIVE`, `Java`, `success`, 
`error`). This means the test suite validates against a phantom contract — real 
regressions like #4732 and #4741 went undetected for weeks because the mocks 
masked the mismatch.
   
   **Impact:** Test suite provides false confidence; any frontend contract 
regression that changes enum values will not be caught by the existing tests.
   
   **Severity:** Medium — no production code is affected, but the test safety 
net is compromised.
   
   **Verification:** PR #4762 from the same author addresses this by aligning 
all fixtures to the real backend values. The fix is test-only (no production 
code changes), and all 75 tests pass with the corrected values.
   
   An automated fix proposal is not needed — the author has already submitted 
PR #4762 with the fix. Maintainers may proceed with reviewing that PR directly.
   
   ---
   *Automated evaluation by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to