Frun1na opened a new pull request, #4823:
URL: https://github.com/apache/rocketmq-dashboard/pull/4823
### Which Issue(s) This PR Fixes
- Fixes #ISSUE_ID
### Brief Description
Two remaining request-body corrections in `docs/api-spec.md`, both read back
from the implementation:
- 3.3 instance update: the document required `{id, name, type, endpoint}`
with all four mandatory. The
endpoint takes `UpdateInstanceDTO`, whose only `@NotBlank` field is
`instanceId` — the globally
unique instance name with a numeric primary-key fallback
(`UpdateInstanceDTO:26-27`,
`InstanceService.resolveInstanceId:447`) — while `name`, `type`,
`endpoint` are optional partial
updates and `remark` / `adminCredentialRef` were not listed at all. Note
the field is spelled
`instanceId`, not `id`.
- 4.14 / 4.15 K8s certificate update & delete: the `id` is a numeric `Long`
(`UpdateCertDTO:34`, `DeleteCertDTO:31`), not a string.
The related string ids I verified and deliberately left untouched, because
the code really takes
strings there: instance delete and ACL user delete/update route through
`DeleteRequestDTO` /
`UpdateAclUserDTO` whose `id` is a `String` identifier (name with numeric
fallback), and
`UpdateConfigDTO.id` for the cluster config update is a `String` too.
### How Did You Test This Change
Documentation-only change; there is no docs build or spec validation to run.
Every claim above was
verified by reading the controller mapping and the DTO field declarations
directly (files and lines
cited).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
