unbridled-41 commented on PR #4813: URL: https://github.com/apache/rocketmq-dashboard/pull/4813#issuecomment-5770233643
Follow-up commit `97f2bbde` addresses a gap found during self-review: the original fix only changed the front-end, but `/api/groups/page` did not accept or apply `subscriptionMode`, so the filter would have remained a no-op against a real backend. What the follow-up adds: - `ConsumerGroupController` accepts `subscriptionMode` as an optional query parameter (blank/`ALL` = no filter, matching the CSV export semantics). - `MetadataService.listConsumerGroupsPage` overload applies the filter to the provider's page result and shrinks the reported total to stay consistent with the rows. - Backend tests: `MetadataServiceTest.listConsumerGroupsPageShouldApplySubscriptionModeFilterToThePage` (Pop filter drops the Push row, total 2→1), `...ShouldIgnoreSubscriptionModeAllAndUnknownValues`, and `ConsumerGroupControllerTest.listConsumerGroupsPageShouldPassSubscriptionModeFilterToTheService` (param passthrough). - Test results: `mvn test -Dtest='MetadataServiceTest,ConsumerGroupControllerTest'` → 57 + 22 tests, 0 failures, BUILD SUCCESS. Front-end suites unchanged and green (37 + 17 passed, tsc/eslint clean). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
