unbridled-41 commented on PR #4832:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4832#issuecomment-5770295994
Evidence-chain verification pass (self-review):
- Re-ran the touched suite from a clean checkout of this branch
(`fix/alerts-total-count-label`, commit `6cfc1b9d`) in an isolated worktree:
`npx vitest run src/pages/ops/__tests__/AlertsPage.test.tsx` → **29 passed
(29)**, `tsc --noEmit` clean.
- Pre-fix failure confirmed: on `origin/rocketmq-studio` the pagination
footer renders `t('alerts.totalRules', { count: 21 })` as exactly `规则总数` (the
`{count}` substitution is a no-op on a template without the placeholder —
verified by simulating `t()`), so the new assertion `getAllByText(/规则总数
21/).length === 2` fails without the fix (footer contributes 0 matches) and
passes with it.
- Both locales covered: the zh assertion (header + footer both carry the
count) and the en test (`Total Rules 7` in both places).
No code changes needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
