RockteMQ-AI commented on issue #4849:
URL:
https://github.com/apache/rocketmq-dashboard/issues/4849#issuecomment-5771039408
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
The reported issue has been verified against the current codebase
(`rocketmq-studio` branch, commit `4c697f07`).
**Root Cause:** `RocketMQClientProvider.mapLanguage` returns `null` for
`LanguageCode` values not in its explicit switch (RUBY, HTTP, OMS, OTHER,
DELPHI, ERLANG). Since `ClientConnectionVO.language` is nullable without
`@JsonInclude(NON_NULL)`, the JSON response contains `"language": null`. The
TypeScript interface in `web/src/api/connections.ts:10` declares `language:
string` (non-nullable), so `strictNullChecks` cannot catch the four unsafe uses
in `clients.tsx`:
1. Distribution chart buckets by `` `${connection.language}
${connection.version}` `` → renders literal "null" label
2. Language column lookup `languageConfig[null]` → empty grey tag
3. Detail drawer same lookup → empty tag
4. CSV export filter compares `String(filterValue) === null` → blank cell
**Impact:** Clients page misrepresents SDK distribution for any non-standard
language client.
**Severity:** Medium — UI rendering issue, no data loss.
**Suggested fix:** Either map unmapped `LanguageCode` values to a sensible
`ClientLanguage` (e.g., add `Other` to the enum), or handle `null`/missing
language gracefully in the frontend (e.g., "Unknown" fallback).
An automated fix proposal can be generated. Reply `/approve` to proceed with
PR generation.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
