unbridled-41 commented on PR #4871: URL: https://github.com/apache/rocketmq-dashboard/pull/4871#issuecomment-5772187374
**Verification pass (fresh checkout of `fix/alert-labels-corrupt-row` @ 363231de)** Code citations in the description were re-checked against the branch: - `NativeAlertProcessor.processSamples` (server/.../ops/alert/NativeAlertProcessor.java:88-94): an evaluation `RuntimeException` is only counted into `failedEvaluations` and logged — the pipeline keeps running with no notifications, confirming the silent-stop claim for the suppression path. - `AlertNotificationSuppressionService.findSuppressingClusterAlert` (AlertNotificationSuppressionService.java:50) pages `findAlertsPage` inside every BUSINESS-domain evaluation, so a corrupt row poisons that shared read path. - The skip/degrade convention citation is `AiConversationService.decode` (server/.../ops/ai/conversation/AiConversationService.java:507-510): "An unreadable payload is skipped rather than fatal". Tests re-executed from a clean checkout of this branch: - `mvn test -Dtest='MybatisPlusAlertRepositoryTest,MybatisPlusAlertStateRepositoryTest,NativeAlertProcessorTest,AlertServiceTest'` → **Tests run: 129, Failures: 0, Errors: 0** (17+83+23+6), BUILD SUCCESS. The description originally said 112 (a sum from the development run); the corrected figure above is the four-class total including the new regression test. - The pre-fix failure (`pageAlertsShouldTolerateACorruptLabelsRowInsteadOfFailingTheQuery` → `IllegalStateException: Unable to read alert labels`) was demonstrated during development by stashing the repository changes with the test in place. Baseline note (pre-existing, unrelated to this PR): `NativeAlertEvaluationTransactionTest` requires a local MySQL and fails with a context-load/connection error on a clean `origin/rocketmq-studio` checkout in this environment (verified on the base commit 4c697f07). It is an environment-dependent test, not a regression of this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
