unbridled-41 commented on PR #4873:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4873#issuecomment-5772215271
**Verification pass (fresh checkout of `fix/related-alerts-reminder-window`
@ f47e512d)**
Code citations in the description were re-checked against the branch:
- `AlertService.findRelatedAlerts` → `SystemAlertController.java:70` (`GET
/api/system-alerts/{id}/related`) is the only caller; the fix changes that read
path only.
- `AlertNotificationSuppressionService.java:67-69` carries the
FIRING/REMINDER in-memory rule and comment the fix mirrors; its query also
passes `transition=null`, so both implementations of the correlation-window
semantic now agree.
- The paging loop mirrors the suppression service's `fetched >=
result.getTotal()` termination (re-verified here as `page *
RELATED_CANDIDATE_PAGE_SIZE >= total`), removing the single-page 100-row
ceiling.
Tests re-executed from a clean checkout of this branch:
- `mvn test
-Dtest='AlertServiceTest,AlertNotificationSuppressionServiceTest,SystemAlertControllerTest'`
→ **Tests run: 102, Failures: 0, Errors: 0** (84+7+11), BUILD SUCCESS.
- Pre-fix failures (development run, repository change stashed with the
tests in place): the new
`relatedAlertsShouldIncludeAnIncidentWhoseInWindowEventIsAReminderTest` failed
because the reminder-only incident was missing from the panel, and
`relatedAlertsShouldReturnOtherDomainFiringEventsInTheSameInstanceAndScopeTest`
failed on the now-removed `transition="FIRING"` query assertion — 2/2 failed as
documented.
One wording correction was made to the description: the original
reproduction sentence described a "FIRING at T−40min" event; the regression
test actually models the incident by its in-window REMINDER row at T−10min
(with a RESOLVED row at T−5min that must stay excluded), and the FIRING event
itself is outside the window. The body now states this precisely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
