unbridled-41 commented on PR #4883: URL: https://github.com/apache/rocketmq-dashboard/pull/4883#issuecomment-5772243914
**Verification pass (fresh checkout of `fix/topic-detail-broadcast-tag` @ caae5c84)** Code citations in the description were re-checked against the branch: - Apache provider path: `RocketMQMetadataProvider.java` (~line 569) sets `messageModel = conn.getMessageModel().name()` (`CLUSTERING`/`BROADCASTING`), with the offline fallback hardcoding `"CLUSTERING"` (line ~590). - Cloud paths: `AliyunConverters.java:159` passes the raw cloud `messageModel` (`Broadcasting`-style); `TencentInstanceProvider.java` (~line 974) passes `subscription.getMessageModel()` (falling back to consumeType) — both spellings contain "broadcast"/"Broadcasting" and are matched by the case-insensitive test. - The compared literal `广播消费` exists only in `web/src/mock/topics.ts:393-423`; the topic detail consumer table renders that same mock data through `getTopicConsumerPage`'s mock branch (topicService.ts), which is why the gap was invisible in dev mode. Tests re-executed from a clean checkout of this branch: - `npx vitest run src/pages/instance/__tests__/TopicPage.test.tsx` → **Test Files 1 passed (1), Tests 33 passed (33)**. - Pre-fix failure (development run, component change stashed with the test in place): `marks a BROADCASTING consumer row with the broadcast tag color in the topic detail` — the `BROADCASTING` row rendered the default blue tag; the test also pins the clustering row to blue. - `npx tsc --noEmit` clean; `npx eslint src/pages/instance/topic.tsx src/pages/instance/__tests__/TopicPage.test.tsx` clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
