zmuxuny commented on PR #4514: URL: https://github.com/apache/rocketmq-dashboard/pull/4514#issuecomment-5771255152
Addressed in `858fe917`, rebased onto `rocketmq-studio@4c697f0`. 1. Accepted the truncation channel: contradictory short/empty message pages now set `mayBeTruncated` and retain collected rows, without introducing a 502. 2. Tencent paging still reuses TaskRequestId. New coverage checks a full first page followed by an incomplete empty second page, retained messages and the next offset/task ID. 3. Added the same known-total check for Aliyun message pages, with completeness measured before local tag filtering. Apache's offset/PullStatus scan is deliberately unchanged; its distinct early-exit/scan-budget contract and the limitation are now explained in the PR scope rather than claiming all three providers are fixed. 4. Extracted `Pagination.isIncompletePage`; both the Tencent resource guard and cloud message loops reuse the predicate, while preserving their different error/degradation policies. 5. Replaced the old throw assertion and added short/nonempty, later-empty and local-filter regressions. The duplicated loop comment is removed. 138/138 focused provider/service/controller/MCP schema tests passed, Checkstyle 0, package succeeds. The PR description includes the exact suites and fail-before evidence; no real provider capture or full datasource integration run is claimed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
