Wang1rrr opened a new pull request, #4914: URL: https://github.com/apache/rocketmq-dashboard/pull/4914
## What is the purpose of the change `TraceNodeVO.status` feeds the `status` prop of the AntD `Steps` component on the message trace page (`web/src/pages/instance/message.tsx`), whose type is the closed vocabulary `wait | process | finish | error` (`web/node_modules/antd/es/steps/index.d.ts`). The Aliyun `GetTrace` adapter passed vendor status strings straight through to that field: - `produceStatus` / `consumeStatus` from `GetTraceResponseBody` (documented examples use `SUCCESS`; client-style traces can carry `SEND_OK`, `CONSUME_OK`, `CONSUME_FAILED`, `PRODUCING`, `CONSUMING`, …) - the tests in `AliyunInstanceProviderTest` already exercised `SEND_OK` and `CONSUME_OK`, and asserted the raw values were returned. Because `SEND_OK` / `SUCCESS` / `CONSUME_FAILED` are not AntD Steps statuses, failed or completed stages were rendered with the default (pending) appearance: a `CONSUME_FAILED` node looked identical to an in-flight one, and the trace timeline no longer communicated outcome. This adds `AliyunConverters.toTraceStatus`, which maps the vendor vocabulary to the Steps vocabulary: - `SUCCESS` / `*OK` → `finish` - `*FAIL*` → `error` - `*ING` (in progress) → `process` - missing or unknown → `wait` (unknown stays unknown, matching the rest of the provider mapping policy) `toTraceRecord` now applies it to producer, consumer-without-records, and per-record consumer nodes. Broker operation nodes keep the default `wait`. ## Brief changelog - `AliyunConverters.toTraceStatus` normalizes vendor trace statuses. - `toTraceRecord` uses it for every status-bearing node. - Tests cover success / ok / failed / in-progress / unknown / missing values and the provider-level trace mapping. ## Verifying this change `mvn -f server/pom.xml test -Dtest='AliyunConvertersTest,AliyunInstanceProviderTest'` Tests run: 40, Failures: 0, Errors: 0 (checkstyle runs at validate and also passes). The updated provider assertions fail on trunk, which returns the raw `SEND_OK` / `CONSUME_OK` strings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
