Wang1rrr opened a new pull request, #4915: URL: https://github.com/apache/rocketmq-dashboard/pull/4915
## What is the purpose of the change `TraceNodeVO.status` is passed straight to the `status` prop of the AntD `Steps` component on the message trace page, whose type is the closed vocabulary `wait | process | finish | error` (`web/node_modules/antd/es/steps/index.d.ts`). The Tencent trace adapter's `toTraceStatus` mapped every non-zero produce / persist status to the literal `"failed"`: ```java return status == 0 ? "finish" : "failed"; ``` `"failed"` is not an AntD Steps status, so a failed produce / persist stage fell through to the component's default (pending) rendering — the same visual defect as the Aliyun raw-status leak, in the sister provider. This changes the mapping to `"error"` and adds a regression test that feeds a produce stage with `Status: 3` and asserts the node status is `"error"`. The existing in-flight consume test (`Status: 1` → `"process"`) continues to pass. ## Brief changelog - `TencentInstanceProvider.toTraceStatus` maps non-zero statuses to `error` instead of `failed`. - `TencentInstanceProviderTest#getMessageTraceMarksFailedProduceAsErrorNotFailed` locks the behaviour. ## Verifying this change `mvn -f server/pom.xml test -Dtest='TencentInstanceProviderTest'` Tests run: 52, Failures: 0, Errors: 0 (checkstyle runs at validate and also passes). The new assertion fails on trunk, which returns `"failed"`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
