Frun1na opened a new pull request, #4936:
URL: https://github.com/apache/rocketmq-dashboard/pull/4936

   ### Which Issue(s) This PR Fixes
   
   - Fixes #(issue to be linked)
   
   ### Brief Description
   
   `createInstance` checks name uniqueness before inserting 
(`requireUniqueInstanceName`), but two concurrent creates can both pass the 
check; the loser then hits the `uk_instance_name` unique key. Only the 
`fk_instance_cloud_credential` violation was translated, so the duplicate-name 
race propagated as a generic `DataIntegrityViolationException` and the user saw 
an opaque 500. The catch block now recognizes the constraint and throws 
`DuplicateInstanceNameException`, the same outcome the sequential case produces.
   
   ### How Did You Test This Change?
   
   ```
   cd server && mvn -B -ntp test -Dtest=InstanceServiceTest
   
   Tests run: 47, Failures: 0, Errors: 0, Skipped: 0
   BUILD SUCCESS
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to