unbridled-41 commented on PR #4948: URL: https://github.com/apache/rocketmq-dashboard/pull/4948#issuecomment-5776890073
Verification, re-executed from the pushed branch (`01d399c9`), not restated from the description. **Command and result** ``` cd server && mvn -o test Tests run: 3153, Failures: 0, Errors: 17, Skipped: 0 ``` The 17 errors are this checkout's environment baseline, not a regression: `grep -c "Failed to load ApplicationContext"` on the log → 21 lines, all `Communications link failure` (there is no MySQL here). The same 17 appear on `origin/rocketmq-studio` before the change. `AiRunServiceTest` 23/23 on the branch (20 before it, 3 added). **Pre-fix reproduction** With the test kept and only `AiRunService.java` restored to `1ef5d860`: ``` AiRunServiceTest.attachShouldReplayABacklogLongerThanOneTimelinePageTest Expecting actual: <200 replayed "agent" frames> to contain: "the newest block" AiRunServiceTest.attachShouldNotLoseAFramePublishedWhileTheReplayIsReadTest Expecting actual: "event:agent" to contain: "published mid-replay" ``` **Coverage statement** The two failing tests cover the two defects: a backlog longer than one page, and a frame published between the replay read and the observer registration. The third new test (`attachShouldDetachTheObserverWhenTheReplayReadFailsTest`) cannot fail on the old code — it guards the registration the fix introduces, so a failed response cannot leave an observer in the registry — and is not counted as pre-fix evidence. **Citations re-checked against the branch** `AiRunService.java:299` `registry.attach` before `replayInto`; `:306-315` the detach-on-throw; `:318-355` `replayInto` with the short-page terminator and the monotonic cursor; page size `AiConversationService.DEFAULT_TIMELINE_LIMIT` (200) as in the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
