unbridled-41 commented on PR #4949: URL: https://github.com/apache/rocketmq-dashboard/pull/4949#issuecomment-5776936091
Verification, re-executed from the pushed branch (`8e337278`), not restated from the description. **Commands and results** ``` cd server && mvn -o test -Dtest='NotificationOutboxServiceTest,AlertSilenceServiceTest,MybatisPlusAlertRepositoryTest,SystemAlertControllerTest,AlertServiceTest,SuppressionServiceTest,NativeAlertProcessorTest' NotificationOutboxServiceTest 29/29, AlertServiceTest 83/83, SystemAlertControllerTest 11/11, NativeAlertProcessorTest 23/23, AlertSilenceServiceTest 12/12, MybatisPlusAlertRepositoryTest 16/16 cd server && mvn -o test -Dtest='AuthServiceDatabaseTest,AuthServiceTest,AuthControllerTest' AuthServiceDatabaseTest 32/32, AuthServiceTest 16/16 cd server && mvn -o test Tests run: 3156, Failures: 0, Errors: 17, Skipped: 0 ``` The 17 errors are this checkout's environment baseline: every failing report contains `Failed to load ApplicationContext` caused by `Communications link failure` (no MySQL here). They are present on `origin/rocketmq-studio` too. **Citations re-checked with `grep -n` on `1ef5d860`** `schema.sql` user table `:18-19`, session `:32-33`, outbox `:375-376`; `RmqAlertNotificationOutboxMapper.java:28-29`; `NotificationOutboxService.java:192,321,367`; `RmqAlertNotificationOutbox.java:24-30` (no `gmtCreate` property); `AuthService.java:283` (the session select), `:306-313` / `:465-472` (the two user inserts), `:339` (enable/disable), `:359-362` (password change), `:393-398` (session insert), `:620-621` (`now()` in UTC); `UserManagement.tsx:81,103-104,398,458`; `deploy/docker-compose.yml:13,86`. One citation in the description was wrong when first written (`schema.sql:24-25` for the user table) and has been corrected to `:18-19`. **Coverage statement** Four write paths are covered: the outbox insert plus its four mutations (asserted through the captured `UpdateWrapper` set clause and through the two raw statements' SQL), the session insert, the user insert, and the user update. `rmq_studio_session.gmt_modified` is intentionally not stamped because nothing reads it — stated in the description so the omission is not read as an oversight. **Pre-fix output reproduced** ``` NotificationOutboxServiceTest.mutationsShouldStampGmtModifiedInsteadOfLeavingItToTheColumnDefaultTest to contain: "gmt_modified=" (actual set clause: status, attempt_count, next_attempt_at, sending_started_at, claim_token, last_error) NotificationOutboxServiceTest.claimedAndRenewedRowsShouldStampGmtModifiedInTheStatementItselfTest [the SQL of claimForDispatch] to contain: "gmt_modified =" AuthServiceDatabaseTest.databaseLoginStampsTheSessionCreationTimeInUtc AuthServiceDatabaseTest.createUserStampsTheBookkeepingColumnsInUtcTest AuthServiceDatabaseTest.disablingAUserStampsItsModificationTimeInUtcTest expected: 2026-08-13T00:00 (java.time.LocalDateTime) but was: null ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
