unbridled-41 commented on PR #4951:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4951#issuecomment-5776938800
Verification, re-executed from the pushed branch (`01d13da6`), not restated
from the description.
**Commands and results**
```
npx vitest run src/pages/instance/__tests__/ConsumerPage.test.tsx → 37/37
npx vitest run src/pages/instance src/utils src/services → 40
files, 396/396
npx tsc --noEmit → clean
npx eslint consumer.tsx ConsumerPage.test.tsx api/metadata.ts → clean
```
**Citations re-checked with `grep -n` on `1ef5d860`**
`ConsumerConnections.java:33-43`, `ConsumerInstanceVO.java:33-40`,
`consumer.tsx:1177` (the 协议 column header), `:1181-1184` (its render),
`:2008-2013` (the health-card verdict),
`consumerGroupDiagnostics.ts:135-138,324,431-432`, `constants/theme.ts:66-69`,
`metadata.ts:115-122`.
One citation was wrong when first written (`LangContext.tsx:38`;
`translations[key]?.[lang] ?? key` is at `:39`) and has been corrected in the
description.
`grep -rn "setLastHeartbeat\|setProtocol(" server/src/main/java` → the only
`protocol(...)` hits are `RocketMQClientProvider.java:331,413` on the
clients-page VO; neither field has a writer on `ConsumerInstanceVO`.
**Pre-fix output reproduced**
With the test kept and only `consumer.tsx` restored to `1ef5d860`:
```
TestingLibraryElementError: Unable to find an element with the text: 不可用.
(the protocol cell); and with that assertion removed:
TestingLibraryElementError: Unable to find an element with the text:
客户端未上报心跳时间.
(the health card)
```
**Coverage statement**
Both halves of the finding are covered by one test, so both are known to
fail on the old code. The 最后心跳 column is deliberately untouched:
`formatDateTime` already renders `-` for a missing value, which is this
application's marker for "no value" and asserts nothing — stated in the
description so the omission is not read as an oversight.
**Related work**
`web/src/pages/instance/consumer.tsx` is touched by several open PRs (#4732,
#4812, #4813, #4773, #4902, #4456, #4494 …). None of them touches the instance
table's columns, the health-card verdict line, or
`consumerGroupDiagnostics.ts`; #4456 is the closest in spirit (it adds an
unavailable label for `delaySeconds`), and it is a different field in a
different file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
