unbridled-41 commented on PR #4953:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4953#issuecomment-5776977696
Verification, re-executed from the pushed branch (`9fa8f5cd`), not restated
from the description.
**Commands and results**
```
npx vitest run src/pages/instance src/components src/hooks → 18 files,
269/269
npx vitest run src/hooks/useInstanceFilter.test.tsx → 3/3
npx vitest run src/pages/instance/__tests__/DLQPage.test.tsx → 22/22
npx vitest run (whole web suite) → 139 files,
1285 tests, 7 failed
npx tsc --noEmit → clean
npx eslint <touched files> → clean
```
**The 7 full-suite failures are load, not regression.** They are
`AlertsPage` (1), `TopicPage` (3) and `ConsumerPage` (3), with per-file wall
times of 170–226 s. `AlertsPage` is not touched by this change at all. Re-run
alone, all three files pass:
```
npx vitest run src/pages/ops/__tests__/AlertsPage.test.tsx
src/pages/instance/__tests__/TopicPage.test.tsx
src/pages/instance/__tests__/ConsumerPage.test.tsx
Test Files 3 passed (3)
Tests 96 passed (96)
```
The same three files pass in isolation on the base revision too, so this is
the environment, not the change.
**Citations re-checked with `grep -n` on `1ef5d860`**
`useInstanceFilter.ts:76-78` (the swallowing catch) and `:87-90` (the
derived `selectedInstanceId`); `topic.tsx:474-481` (clear-and-stop) with
`loadTopicPage` bailing at `:439`; `consumer.tsx:381-390`; `dlq.tsx:188-199`;
`acl.tsx:128,135-136`; `message.tsx:493-497`.
The description previously lumped `acl.tsx`/`message.tsx` into "the same
shape"; that was wrong and has been corrected — `message.tsx` does show a hint,
it just asks the user to select an instance from a list that could not be
loaded.
**Pre-fix output reproduced**
With the page test kept and all touched source files restored to `1ef5d860`:
```
FAIL src/pages/instance/__tests__/DLQPage.test.tsx > DLQ page > says so when
the instance list itself failed to load
TestingLibraryElementError: Unable to find an element with the text:
实例列表加载失败.
```
**Coverage statement**
That test is the pre-fix evidence. The hook test (`reports a failed instance
list and recovers from a retry`) reads the new fields, so it cannot run against
the old code; it guards the retry path and is not counted as pre-fix evidence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
