zmuxuny commented on PR #4504: URL: https://github.com/apache/rocketmq-dashboard/pull/4504#issuecomment-5771311228
Addressed the read/catalog review together in `07f4989`, rebased onto `rocketmq-studio@4c697f0`. The evidence limitation is explicit: I do not have a captured HTTP 200 / success=false cloud response. The revised policy uses 422 for an explicit Boolean.FALSE business rejection, not 502; omitted success flags are accepted. A null response/body is consistently a malformed-response 502 across read/catalog/trace, while a present body with no data retains empty/not-found semantics. All nine provider and three catalog sites now share the type-safe `AliyunResponseValidator` in common/util, including StringUtils.hasText and message/code fallback. New tests pin missing-flag compatibility, missing-envelope errors, explicit rejection, and HTTP 422/envelope propagation. The merged send path and the rejected mutation proposal #4499 were not changed or reintroduced. 171/171 focused tests passed, Checkstyle 0, package succeeds. A separate combined snapshot with #4514 also passed 246/246 tests with a clean Git merge. The PR now fixes both #4500 and #4505; #4507 is being closed as consolidated here, not as an upstream merge. Full datasource integration and live cloud-credential testing were not performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
