X-LightYear opened a new pull request, #4982: URL: https://github.com/apache/rocketmq-dashboard/pull/4982
## Summary - reject blank or whitespace-only ACL rule principals during Apache rule updates - reject blank or whitespace-only ACL rule resources during Apache rule updates - add deterministic service-level regression coverage before repository access ## Root cause `AclService.createRule` validates `principal` and `resource`, but the Apache branch of `AclService.updateRule` only validated the rule ID before calling `aclRepository.replaceRule`. Invalid rule metadata could therefore proceed to lookup and persistence. ## Fix Apply the same `StringUtils.hasText` validation to Apache rule updates after the existing ID check. The provider-specific Tencent branch remains unchanged. ## Testing - focused ACL regression tests: 2 passed - `AclServiceTest`: 80 passed - Maven Checkstyle: 0 violations - `mvn -Dmaven.compiler.proc=full -DskipTests package`: passed - full Maven test suite: 3152 tests executed; unrelated database-backed integration contexts failed because no local test database was available - `git diff --check`: passed Fixes #4981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
